-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Make all jsx-prop-sort lints fixable #2250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not all the prop sort lints were fixable. There were cases when fix would mess other things up. For example, in case when normal props were not sorted but callback functions were in the end(As they are supposed to be), sorting lint fix would mix oncallback props in between the other props. Updated the tests accordingly.
@ljharb Thank you for so fast review Jordan. |
@ljharb @yannickcr Would appreciate if you cut the new tag. |
Yes, tests are failing on master right now; see #2253 |
v7.13.0 is released. |
Thank you @ljharb . Appreciated :) |
Not all the jsx-prop-sort lints were fixable.
There were cases when existing fix would cause other lints to trigger.
For example, in case when normal props were not sorted but callback functions were in the end(As they are supposed to be), sorting lint fix would mix callbacks props in between the other props.
Updated the tests accordingly.