fix(jsx-key): handle shorthand fragment syntax #2316
Merged
+51
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In eslint/eslint#9664 eslint added support for the shorthand fragment syntax (
<></>
) as a new node type:JSXFragment
. The jsx-key rule hasn't been updated to handle it correctly so in some cases where it should report errors it doesn't. Here is an exampleThis PR fixes this and adds some tests. The error messages could probably be improved and maybe we should add an example to the docs?