Handle react version detect errors

[abhishekdev]

What does this fix

The fix to #2276 (commit golopot@e2e246a) caused a regression only for scenarios where react version cannot be detected. Once the first warning is logged, a second try always results in the raw error being thrown and failure of the lint process.

Warning: React version was set to "detect" in eslint-plugin-react settings, but the "react" package is not installed. Assuming latest React version for linting.
Error: Error while loading rule 'react/jsx-no-bind': Cannot find module 'react' from 'project-path'
Occurred while linting project-path/.eslintrc.js
    at Function.module.exports [as sync] (project-path/node_modules/resolve/lib/sync.js:71:15)
    at detectReactVersion (project-path/node_modules/eslint-plugin-react/lib/util/version.js:19:31)
    at getReactVersionFromContext (project-path/node_modules/eslint-plugin-react/lib/util/version.js:39:25)
    at Object.testReactVersion (project-path/node_modules/eslint-plugin-react/lib/util/version.js:107:35)
    at usedPropTypesInstructions (project-path/node_modules/eslint-plugin-react/lib/util/usedPropTypes.js:271:48)
    at Function.componentRule (project-path/node_modules/eslint-plugin-react/lib/util/Components.js:763:37)
    at createRuleListeners (project-path/node_modules/eslint/lib/linter/linter.js:697:21)
    at Object.keys.forEach.ruleId (project-path/node_modules/eslint/lib/linter/linter.js:865:31)
    at Array.forEach (<anonymous>)
    at runRules (project-path/node_modules/eslint/lib/linter/linter.js:810:34)
npm ERR! Test failed.  See above for more details.

Solution

The warnedForMissingVersion flag should only control the warning message and not the handling of the error (which was the previous behavior)

I have included a test that ensures only a single error is present in stack. The issue can be reproduced by going back to the test commit. Here is the output for the case when it fails (i.e. before this fix):

 2) Version
       "after each" hook for "warns only once for failure to detect react ":

      AssertionError [ERR_ASSERTION]: [ [ 'Warning: React version was set to "detect" in eslint-plugin-react settings, but the "react" package is not installed. As... deepEqual []
      + expected - actual

      -[
      -  [
      -    "Warning: React version was set to \"detect\" in eslint-plugin-react settings, but the \"react\" package is not installed. Assuming latest React version for linting."
      -  ]
      -]
      +[]
      
      at Context.afterEach (tests/util/version.js:26:12)