Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2358 by recognizing props wrapped in $ReadOnly<> #2361

Merged
merged 1 commit into from Jul 28, 2019
Merged

Fix #2358 by recognizing props wrapped in $ReadOnly<> #2361

merged 1 commit into from Jul 28, 2019

Conversation

lukeapage
Copy link
Contributor

@lukeapage lukeapage commented Jul 26, 2019 •
edited by ljharb

Fixes #2358.

@lukeapage
Copy link
Contributor Author

Not sure why the build fails - I don’t see how it could be related to my changes. The same error happened on master a month ago:

https://travis-ci.org/yannickcr/eslint-plugin-react/builds/551059139

@jomasti
Copy link
Contributor

jomasti commented Jul 27, 2019 •
edited

There are two ESLint errors related to your changes that are causing that failure. Lines 651-652 of the log are specifically the cause of the failure.

@lukeapage
Copy link
Contributor Author

Thanks! I'm not used to a project with many warnings, I missed the fact there were 2 errors.

ljharb
ljharb requested changes Jul 27, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, plus let’s rebase these down to one commit, and it’s good to go!

lib/util/propTypes.js Outdated Show resolved Hide resolved
@lukeapage
Copy link
Contributor Author

okay, done

@ljharb ljharb merged commit 5bdc98c into jsx-eslint:master Jul 28, 2019
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 10, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 13, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 21, 2020
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
bug flow
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-unused-prop-types doesn't report errors on readonly props
3 participants
@lukeapage @jomasti @ljharb