Require Optimization breaks when using arrow function Fix #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Aug 17, 2019
ljharb
force-pushed
the
require-optimization-fix
branch
from
8ed122e
to
57e2d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2374
Issue
require-optimization breaks when using arrow function in class components.
What went wrong
When we encounter
ArrowFunctionExpressionwe blindly callsmarkSCUAsDeclared. In case of functional components it works fine, but in case of class based components, callingmarkSCUAsDeclaredsets SCU declared for that component as true.Added a check, if
ArrowFunctionExpressionis part of a class, then ignore it.