[New] Add jsx-no-script-url to prevent usage of javascript: URLs
#2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-startsev
force-pushed
the
jsx-no-script-url
branch
from
9ec97c4
to
92f3cef
Compare
ljharb
reviewed
Oct 1, 2019
sergei-startsev
force-pushed
the
jsx-no-script-url
branch
4 times, most recently
from
3285ca7
to
01d9fec
Compare
ljharb
reviewed
Oct 8, 2019
sergei-startsev
force-pushed
the
jsx-no-script-url
branch
from
01d9fec
to
2f267ca
Compare
ljharb
reviewed
Nov 29, 2019
ljharb
force-pushed
the
jsx-no-script-url
branch
from
2f267ca
to
7c44126
Compare
sergei-startsev
force-pushed
the
jsx-no-script-url
branch
2 times, most recently
from
c435347
to
24ab5df
Compare
ljharb
approved these changes
Nov 30, 2019
ljharb
force-pushed
the
jsx-no-script-url
branch
from
24ab5df
to
2ecdf36
Compare
|
Should this be added to the recommended config? |
|
Not at this time, adding things to the recommended config is a breaking change. If we ever are forced to do a semver-major, then we'll re-evaluate the recommended config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In React 16.9 any URLs starting with
javascript:scheme log a warning. React considers the pattern as a dangerous attack surface, see details and in a future major release it will throw an error if it encounters ajavascript:URL.The rule prevents usage of
javascript:URLs in JSX.