fix(jsx-curly-brace-presence): allow necessary white-space literal #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Oct 3, 2019
ljharb
force-pushed
the
fix/jsx-curly-brace-presence
branch
from
d1ec25f
to
4c89872
Compare
ljharb
reviewed
Oct 3, 2019
ljharb
force-pushed
the
fix/jsx-curly-brace-presence
branch
from
4c89872
to
156e9f5
Compare
…` for back compat
ljharb
force-pushed
the
fix/jsx-curly-brace-presence
branch
3 times, most recently
from
023be90
to
6f14e16
Compare
eventualbuddha
added a commit
to votingworks/bmd
that referenced
this pull request
Oct 7, 2019
This was incorrectly removed by eslint-plugin-react v7.15.x due to a bug. It's been fixed in jsx-eslint/eslint-plugin-react#2437, so this commit updates eslint-plugin-react and re-adds the whitespace.
eventualbuddha
added a commit
to votingworks/bmd
that referenced
this pull request
Oct 7, 2019
This was incorrectly removed by eslint-plugin-react v7.15.x due to a bug. It's been fixed in jsx-eslint/eslint-plugin-react#2437, so this commit updates eslint-plugin-react and re-adds the whitespace.
This was referenced Dec 11, 2019
This was referenced Feb 10, 2020
beausmith
pushed a commit
to votingworks/vxsuite
that referenced
this pull request
Nov 2, 2020
This was incorrectly removed by eslint-plugin-react v7.15.x due to a bug. It's been fixed in jsx-eslint/eslint-plugin-react#2437, so this commit updates eslint-plugin-react and re-adds the whitespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks against use-case where white space literal is used to pad around JSX across newlines.