Add section about overriding for trusted links #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Oct 4, 2019
docs/rules/jsx-no-target-blank.md
Outdated
| @@ -74,6 +74,9 @@ var Hello = <Link target="_blank" to="/absolute/path/in/the/host"></Link> | |||
| var Hello = <Link /> | |||
| ``` | |||
|
|
|||
| ## When To Override It | |||
| For internal links, or links to a "safe" host, you may want to keep the HTTP Referer header for analytics purposes. | |||
There was a problem hiding this comment.
can you elaborate on what you mean by "safe"?
There was a problem hiding this comment.
I updated with additional text. To elaborate further on the reason for this change: this lint rule and the linked page make it sound like one should never use target="_blank" without noreferer and noopener. However, as I understand, if you control the site to which you are linking, there is no vulnerability. And there are good reasons to keep the referer header (e.g. interal analytics/tracking).
ljharb
approved these changes
Oct 12, 2019
This was referenced Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.