Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find target={'_blank'} expressions #2451

Merged

Conversation

timkraut
Copy link
Contributor

@timkraut timkraut commented Oct 7, 2019

The jsx/no-target-blank rule does not detect the _blank value if written as an expression containing a string (such as target={'_blank'}). This PR fixes that.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to call this a minor, because it's a bugfix, but it will potentially result in more warnings for some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants