New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] props-no-multi-spaces
: suggest using core rule instead
#2463
Conversation
This is not accurate. The core rules do not provide sufficient jsx indentation control; the proper thing to do is disable the eslint core rule for all jsx, as the airbnb config does, and rely on this plugin to handle all jsx indentation. |
I believe the capability of the core rule |
Not off the top of my head, but the airbnb config ignores jsx here: https://github.com/airbnb/javascript/blob/ab72ab9e90f403e90590f8815e0563248af10470/packages/eslint-config-airbnb-base/rules/style.js#L146 and sets all the react rules here: https://github.com/airbnb/javascript/blob/ab72ab9e90f403e90590f8815e0563248af10470/packages/eslint-config-airbnb/rules/react.js If in fact every single permutation of our rules are possible with core, then this is fine to merge, but until then, the core indent rule should not be used with jsx whatsoever. |
The core rule does not offer compatibility with every single permutation of our indent rules, so I will drop that part. I amended this pr to only deal with |
props-no-multi-spaces
: suggest using core rule instead
No description provided.