[Fix]: false positives for no-unused-... when using TS type assertions
#2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when using TS type assertions Fixes #2517 - add `unwrapTSAsExpression` to `lib/util/ast` - change `as any` assertions in tests to `as unknown` - add failing test cases
ljharb
reviewed
Jan 1, 2020
ljharb
requested changes
Jan 7, 2020
ljharb
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2517:
asassertion.no-unused-prop-typesno-unused-stateI tried to reuse as much of the existing solution as possible by handling cases where the
asexpression might occur.I'm wondering tho if it would be better to just process the code with anything that would remove TS-specific syntax (type annotations,
asassertions, etc.) and then parse the result so the entire logic could be reused. Just thinking out loud 😅