[Fix] jsx-indent: Does not check indents for JSXText

[toshi-toma]

Fixes #2467, Fixes #2484, Fixes #1136
This PR fixes the problem of does not check jsx-indent for JSXText.

JSXText Node is different from other formats.
e.g. The following code. JSXText's node.value returns \n text\n text\n .

const f = () => (
    <div>
        text
        text
    </div>
);

changes

1. add handler for JSXText Node
   https://github.com/yannickcr/eslint-plugin-react/blob/0076cb09abfed7a3777102359efb5f39dee2e01e/lib/rules/jsx-indent.js#L406-L412

2. check JSXText Indent
   https://github.com/yannickcr/eslint-plugin-react/blob/0076cb09abfed7a3777102359efb5f39dee2e01e/lib/rules/jsx-indent.js#L304-L341

3. add the fix for JSXText
   https://github.com/yannickcr/eslint-plugin-react/blob/0076cb09abfed7a3777102359efb5f39dee2e01e/lib/rules/jsx-indent.js#L100-L104

4. add test cases
   tests/lib/rules/jsx-indent.js

[ljharb]

Thanks, this looks great!

[ljharb]

there's no need to hardcode this when https://npmjs.com/string.prototype.matchall exists; please use that instead.

[ljharb]

this whole body can then be replaced with:

return match[1] ? match[1].length : 0;

[toshi-toma]

@ljharb
Thank you for the review!!
I fixed.

but, CI is failed...
The cause is JSXText only available Node to ESLint v5 or more.
eslint/eslint#10152

What do you think about supporting the ESLint version?

[ljharb]

@toshi-toma is there no way to identify text inside JSX in eslint < 5? It seems pretty likely that there is something, it's just got a different node type.

[golopot]

In older eslint (and current babel-eslint), the node type of text inside JSX is Literal.

[toshi-toma]

@ljharb
I fixed to work for older eslint. and fixed some tests.
Now, CI is failing in Node v4...
I can't understand the cause.

[ljharb]

This caused #2561, which was fixed in 3da6eb3 - namely, the issue was that the literal check assumed strings.