Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] jsx-sort-props: only use localeCompare when case is ignored #2556

Merged
merged 1 commit into from May 12, 2020
Merged

[Fix] jsx-sort-props: only use localeCompare when case is ignored #2556

merged 1 commit into from May 12, 2020

Conversation

tanmoyopenroot
Copy link
Contributor

PR checklist

Overview of change:

remove the use of localCompare

@tanmoyopenroot @ljharb
[Fix] jsx-sort-props: only use localeCompare when case is ignored
f94d851 
Fixes jsx-eslint#2381. Fixes jsx-eslint#2530.

Co-authored-by: tanmoyopenroot <tanmoy.openroot@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@ljharb ljharb force-pushed the 2530-fix-react/jsx-sort-props branch from be370a0 to 7e6bcdf Compare May 12, 2020 22:06
@ljharb ljharb changed the title 2530: fix - react/jsx sort props [Fix] jsx-sort-props: only use localeCompare when case is ignored May 12, 2020
@ljharb ljharb force-pushed the 2530-fix-react/jsx-sort-props branch from 7e6bcdf to f94d851 Compare May 12, 2020 23:37
@ljharb ljharb merged commit f94d851 into jsx-eslint:master May 12, 2020
This was referenced Mar 15, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react/jsx-sort-props gets confused when props are sorted with --fix but one has camelCase
2 participants
@tanmoyopenroot @ljharb