[tests] delete test cases that became parsing error after acorn-jsx@5.2.0 #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… errors in acorn-jsx@5.2.0 Co-authored-by: Chiawen Chen <golopot@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
|
Has an issue been filed upstream for the breaking change in a minor release? |
|
Looks like they unfortunately made an intentional breaking change in a minor version. |
ljharb
force-pushed
the
fix-tests-in-no-unescaped-entries
branch
from
4399661
to
241611c
Compare
|
I've gone ahead and updated the tests so they're kept when acorn-jsx is < 5.2, and skipped when it's absent or when it's >= 5.2. That way they can still run on eslint 4, for example: https://travis-ci.org/yannickcr/eslint-plugin-react/builds/657558888 |
ljharb
approved these changes
Mar 3, 2020
ljharb
force-pushed
the
fix-tests-in-no-unescaped-entries
branch
from
241611c
to
e231f44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is failing after the release of acorn-jsx@5.2.0, 4 days ago, which is a dependency of espree. https://github.com/acornjs/acorn-jsx/releases/tag/5.2.0. That release introduced a breaking change that forbids
>and}in JSXText. Therefore codes like<p>></p>became a parsing error.This PR removed test cases that became parsing error after acorn-jsx@5.2.0.
An expensive alternative is to setup tests for both acorn-jsx < 5.2.0 and > 5.2.0. But that is expensive.