Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no-comment-text-nodes for @typescript-eslint/parser #2601

Merged
merged 1 commit into from Mar 23, 2020
Merged

Fix no-comment-text-nodes for @typescript-eslint/parser #2601

merged 1 commit into from Mar 23, 2020

Conversation

Axnyff
Copy link
Contributor

@Axnyff Axnyff commented Mar 23, 2020 •
edited by ljharb

Fixes #2599.

@Axnyff @ljharb
[Fix] jsx-no-comment-textnodes: fix for @typescript-eslint/parser
6aa7874 
 - `@typescript-eslint/parser` requires eslint 5+ (and node 6+)

Fixes #2599.
@Axnyff Axnyff mentioned this pull request Mar 23, 2020
Closed
ljharb
ljharb approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've incorporated your fix as well.

@ljharb ljharb merged commit 6aa7874 into jsx-eslint:master Mar 23, 2020
@Axnyff
Copy link
Contributor Author

Axnyff commented Mar 23, 2020

Thanks for your time and help!

@crupest crupest mentioned this pull request May 13, 2020
Merged
@gone-skiing gone-skiing mentioned this pull request May 13, 2020
Closed
This was referenced Mar 15, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-comments-in-text-node seems to be broken with @typescript-eslint/parser
2 participants
@Axnyff @ljharb