Relax JSX pragma regexp #2643
Merged
Relax JSX pragma regexp #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
May 17, 2020
|
|
|
@ljharb I've added the tests |
ljharb
reviewed
Jun 5, 2020
|
|
||
| const assert = require('assert'); | ||
| const SourceCode = require('eslint').SourceCode; | ||
| const espree = require('espree'); |
There was a problem hiding this comment.
is there any way to do this with eslint itself, rather than adding a dev dep on espree?
There was a problem hiding this comment.
Not as far as I could tell, unfortunately. I tried using eslint first, but eslint does not expose the API to generate the AST object needed to create the SourceCode object.
ljharb
force-pushed
the
bugfix/2642-jsx-pragma-matching-too-strict
branch
from
d2ce572
to
ef9a512
Compare
ljharb
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2642.
This PR relaxes the JSX pragma detection slightly.
Previously, only pragmas at the beginning of docstring comments were recognised. But pragmas can occur anywhere in any block comment (not just docstring comments). This PR fixes the regexp that recognises pragmas.