[Fix]:prop-types: handle component returning null
#2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jul 6, 2020
hank121314
changed the title
prop-types: handle nullable component in propTypesprop-types: handle nullable component in propTypes and [Fix]:no-unused-prop-types: fix typo in testcase
This was referenced Jul 9, 2020
ljharb
changed the title
prop-types: handle nullable component in propTypes and [Fix]:no-unused-prop-types: fix typo in testcaseprop-types: handle nullable component in propTypes
ljharb
changed the title
prop-types: handle nullable component in propTypesprop-types: handle component returning null
ljharb
approved these changes
Jul 10, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is related to #2654 (comment)
Previous isJSXFunctionComponent did not handle nullable component correctly.
So I replaced it with utils.isReturningJSXOrNull.
Sorry for the issue.
Fixes #2705.