[Fix] jsx-no-literals with allowStrings doesn't work in props #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolina-benitez
changed the title
ljharb
requested changes
Aug 1, 2020
| } | ||
| `, | ||
| options: [{noStrings: true, allowedStrings: ['button', 'submit']}], | ||
| parser: parsers.BABEL_ESLINT |
There was a problem hiding this comment.
let's also add the same test case for each of the other parsers (default, and both typescript-eslints)
There was a problem hiding this comment.
Can you please clarify?
There was a problem hiding this comment.
This test case works for babel-eslint; but the same test case should pass on the default parser, and on the old typescript-eslint, and on the new typescript eslint parser.
There was a problem hiding this comment.
Thanks, added!
karolina-benitez
force-pushed
the
Issue2720
branch
from
dc6665e
to
c5da190
Compare
ljharb
approved these changes
Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if props string is included in
allowedStringsoptionFixes #2720.