[New] prop-types: add support for PropTypes.exact
#2740
Conversation
| @@ -422,13 +422,14 @@ module.exports = function propTypesInstructions(context, components, utils) { | |||
| const callName = value.callee.property.name; | |||
| const argument = value.arguments[0]; | |||
| switch (callName) { | |||
| case 'shape': { | |||
| case 'shape': | |||
| case 'exact': { | |||
There was a problem hiding this comment.
i don't think this should be included here - i think it should be a default member of propWrapperFunctions. Otherwise, how can you turn it off?
Also, when the installed prop-types package doesn't have exact, it should not be supported.
There was a problem hiding this comment.
@ljharb
But why we would turn it off? exact has been part of the library since 2017 from what I see.
About validating that prop-types is installed, that would make us more correct but is not like React.PropTypes.exact is going to work anyway. In that case the user would get a ReferenceError on exact, I think.
There was a problem hiding this comment.
Because someone might be using an older version of the library. There's lots of precedent; this plugin dynamically looks up the keys on require('prop-types') in order to determine what's available.
React.PropTypes.exact might work if a) the pragma isn't "React", b) they'd done React.PropTypes = require('prop-types');.
There was a problem hiding this comment.
Because someone might be using an older version of the library. There's lots of precedent; this plugin dynamically looks up the keys on require('prop-types') in order to determine what's available.
Yeah, but the rule no-types works the user having the library installed or not since this project already has it as a dependency:
Doing as suggested in comment #2590 (comment) would result in exact always being included since the library would always resolve to the internal version of prop-types.
React.PropTypes.exact might work if a) the pragma isn't "React", b) they'd done React.PropTypes = require('prop-types');
Added two more tests for this cases.
There was a problem hiding this comment.
Hmm, that is a fair point on the prop-types dep.
There was a problem hiding this comment.
But we can still do it right.
The only rule that depends on prop-types is no-typos.
So, to correctly feature detect exact what do you think if I change prop-types to a dev dependency, check for the existent of prop-types before requiring it and fix no-typos to not validate prop-types names if the lib is not present.
There was a problem hiding this comment.
The intention in no-typos is that when new validators are added, they're suggested by default, without needing a change in this library.
ljharb
force-pushed
the
feat/add-exact-proptypes-support
branch
from
ac3d11a
to
7850e57
Compare
ljharb
changed the title
prop-types: add support for PropTypes.exact
Closes #2590