[Fix] Improve error message for no-find-dom-node #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Aug 6, 2020
lib/rules/no-find-dom-node.js
Outdated
| @@ -40,7 +40,7 @@ module.exports = { | |||
|
|
|||
| context.report({ | |||
| node: callee, | |||
| message: 'Do not use findDOMNode' | |||
| message: 'Do not use findDOMNode. It doesn\'t work with function components and is deprecated in StrictMode. See https://reactjs.org/docs/react-dom.html#finddomnode' | |||
There was a problem hiding this comment.
Suggested change
| message: 'Do not use findDOMNode. It doesn\'t work with function components and is deprecated in StrictMode. See https://reactjs.org/docs/react-dom.html#finddomnode' | |
| message: 'Do not use findDOMNode. It doesn‘t work with function components and is deprecated in StrictMode. See https://reactjs.org/docs/react-dom.html#finddomnode' |
straight quotes are always typographically incorrect in prose :-)
There was a problem hiding this comment.
I believe you meant to use the right single quotation mark ’ rather than the left one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message for
no-find-dom-nodewasn't very informative, which makes it less likely that people will respect the rule instead of just disabling it. This PR adds a more informative message.