Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test]prop-types: add test #2757

Merged
merged 1 commit into from Aug 17, 2020

Conversation

jzabala
Copy link
Contributor

@jzabala jzabala commented Aug 14, 2020

It is working. Adding test.

Closes #2747

@jzabala
Copy link
Contributor Author

jzabala commented Aug 16, 2020

@ljharb the issue for this PR was closed. Since this only adds a test I don't know if you want to add or close it.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to add more tests :-)

@ljharb ljharb force-pushed the test/add-test-for-prop-types-rule branch from 805ae08 to 2588c4d Compare August 17, 2020 06:32
@ljharb ljharb merged commit 2588c4d into jsx-eslint:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

react/prop-types not detecting props when defined as an interface
2 participants