Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] forbid-component-props: Implemented support for "namespaced" components. #2767

Merged

Conversation

mnn
Copy link

@mnn mnn commented Aug 24, 2020

I don't really know what I am doing. I have just looked at the structure of the node, added a test and updated code so the tests pass.

Fixes #2766.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! Made some small tweaks, but just one question:

lib/rules/forbid-component-props.js Outdated Show resolved Hide resolved
@ljharb ljharb changed the title [New] forbid-component-props: Implemented support for "namespaced" components. [Fix] forbid-component-props: Implemented support for "namespaced" components. Aug 30, 2020
@ljharb ljharb force-pushed the forbid-component-props--namespaced-components branch from 3924844 to 6a34b8e Compare August 30, 2020 20:57
@ljharb ljharb force-pushed the forbid-component-props--namespaced-components branch from 6a34b8e to d6ee945 Compare August 30, 2020 21:49
@ljharb ljharb merged commit d6ee945 into jsx-eslint:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

forbid-component-props: How to distinguish a component from a library?
2 participants