function-component-definition: ignore properties #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Aug 29, 2020
ljharb
approved these changes
Aug 30, 2020
ljharb
force-pushed
the
master
branch
2 times, most recently
from
a00e067
to
20103c5
Compare
|
Well, the test cases this PR uses should all have been ignored based on PascalCase alone. I don't see a test for it in lib/rules/function-component-definition.js either. |
|
(this was in reply to the issue, sorry, on phone) |
|
@wmertens yes, ignored because they're not PascalCase. |
|
@ljharb no, they weren't ignored before this PR, this PR only adds being part of an object |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2765