Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] jsx-closing-bracket-location: In tag-aligned, made a distinction between tabs and spaces #2796

Merged
merged 1 commit into from Sep 16, 2020

Conversation

Moong0122
Copy link
Contributor

@Moong0122 Moong0122 commented Sep 16, 2020

To differentiate between tab and space, modified lib/rules/jsx-closing-bracket-location
and added test case in tests/lib/rules/jsx-closing-bracket-location.

PR fixes #756

@Moong0122 Moong0122 changed the title [Fix] In tag-aligned, made a distinction between tabs and spaces #756 [Fix] In tag-aligned, made a distinction between tabs and spaces Sep 16, 2020
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks!

@ljharb ljharb changed the title [Fix] In tag-aligned, made a distinction between tabs and spaces [Fix] jsx-closing-bracket-location: In tag-aligned, made a distinction between tabs and spaces Sep 16, 2020
@ljharb ljharb merged commit 7434f19 into jsx-eslint:master Sep 16, 2020
@Moong0122 Moong0122 deleted the issue-756 branch September 28, 2020 11:57
@Moong0122 Moong0122 restored the issue-756 branch September 28, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

jsx-closing-bracket-location think of 'space' and 'tab' as the same thing
2 participants