Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Detect JSX returned by sequential expression #2801

Merged
merged 1 commit into from Sep 20, 2020
Merged

[Fix] Detect JSX returned by sequential expression #2801

merged 1 commit into from Sep 20, 2020

Conversation

mikol
Copy link
Contributor

@mikol mikol commented Sep 20, 2020

Resolves #2800. Implements isReturnsSequentialJSX() and uses it in isReturningJSX() (in conjunction with isReturnsConditionalJSX() and isReturnsLogicalJSX()).

@mikol mikol force-pushed the mikol/2800/returns-sequential-jsx branch from 866f20e to c106582 Compare September 20, 2020 01:50
@mikol @ljharb
[Fix] prop-types: Detect JSX returned by sequential expression
74c4eed 
Resolves jsx-eslint#2800. Implements `isReturnsSequentialJSX()` and uses it in
`isReturningJSX()` (in conjunction with `isReturnsConditionalJSX()` and
`isReturnsLogicalJSX()`).
@mikol mikol force-pushed the mikol/2800/returns-sequential-jsx branch from c106582 to dec2975 Compare September 20, 2020 01:53
@ljharb ljharb force-pushed the mikol/2800/returns-sequential-jsx branch 2 times, most recently from 5f9876e to 74c4eed Compare September 20, 2020 22:02
@ljharb ljharb merged commit 74c4eed into jsx-eslint:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prop types aren’t checked if JSX is returned in a sequential expression (e.g., return 0, <div/>)
2 participants
@mikol @ljharb