[Fix] prop-types: handle RestElement in destructured param
#2805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for the quick review! |
|
Same problem with |
|
@alexfdz an issue, or better, a PR with a failing test case, would be appreciated (and would be fixed the fastest) |
|
Not fixed yet, e.g. |
minwe
added a commit
to minwe/eslint-plugin-react
that referenced
this pull request
Sep 27, 2020
…r when destructured param see jsx-eslint#2805, jsx-eslint#2804, jsx-eslint#2805 (comment)
|
@ljharb I have fixed error got when |
ljharb
pushed a commit
to minwe/eslint-plugin-react
that referenced
this pull request
Sep 27, 2020
…r when destructured param see jsx-eslint#2805, fixes jsx-eslint#2804, jsx-eslint#2805 (comment)
artem0723
pushed a commit
to artem0723/React-Eslint-Plugin
that referenced
this pull request
Aug 27, 2021
…r when destructured param see #2805, fixes #2804, jsx-eslint/eslint-plugin-react#2805 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr fixes: #2804 .
Function parameter will have
RestElementwhich do not have property value.It will cause undefined property error.