Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-unused-prop-types: Silence false positive on never type in TS #2815

Merged
merged 1 commit into from Oct 3, 2020

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Oct 1, 2020

Adding the type never is enforcing that the prop types is actually never set, so it's redundant to warn about this prop type not being used.


This change is Reviewable

@ljharb ljharb changed the title [no-unused-prop-types] Silence false positive on never type in TS. [Fix] no-unused-prop-types: Silence false positive on never type in TS Oct 3, 2020
@ljharb ljharb added the hacktoberfest-accepted If you're interested in a free shirt, this PR counts towards it. label Oct 3, 2020
@ljharb ljharb merged commit 71a0e8f into jsx-eslint:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted If you're interested in a free shirt, this PR counts towards it. typescript
Development

Successfully merging this pull request may close these issues.

None yet

2 participants