[Fix] destructuring-assignment, no-multi-comp, no-unstable-nested-components, component detection: improve component detection

[vedadeepta]

Fixes: #2956

Description:

Example code that shows incorrect error:

const columns = [
  {
    render: (val) => {
      if (val.url) {
        return (
          <a href={val.url} rel="noopener noreferrer" target="_blank">
            {val.fileName || 'PDF'}
          </a>
        );
      }
      return null;
    },
  },
];

Error shows up because getParentComponent calls getParentStatelessComponent that calls getStatelessComponent on the ArrowFunctionExpression (val =>...) in the example code above which incorrectly returns the same ArrowFunctionExpression instead of undefined.

[codecov-commenter]

Codecov Report

Merging #3001 (79a7bcc) into master (faadccb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3001   +/-   ##
=======================================
  Coverage   97.21%   97.22%           
=======================================
  Files         110      110           
  Lines        7297     7305    +8     
  Branches     2657     2663    +6     
=======================================
+ Hits         7094     7102    +8     
  Misses        203      203           

Impacted Files	Coverage Δ
lib/util/Components.js	95.36% <100.00%> (+0.07%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faadccb...79a7bcc. Read the comment docs.

[yoyo837]

Thanks for your work.

[ThiefMaster]

Not sure if it's caused by the changes in this PR, but after updating from 7.24 to 7.26, I noticed a bunch of false positives showing up in my code:

.../indico/modules/events/editing/client/js/editing/timeline/util.js
  55:14  warning  Must use destructuring revision assignment  react/destructuring-assignment

.../indico/modules/rb/client/js/common/map/reducers.js
  59:9  warning  Must use destructuring action assignment  react/destructuring-assignment
  64:9  warning  Must use destructuring action assignment  react/destructuring-assignment

• https://github.com/indico/indico/blob/676dc3d1fede9bd4417982e79310753691be2472/indico/modules/rb/client/js/common/map/reducers.js#L59
• https://github.com/indico/indico/blob/676dc3d1fede9bd4417982e79310753691be2472/indico/modules/rb/client/js/common/map/reducers.js#L64
• https://github.com/indico/indico/blob/676dc3d1fede9bd4417982e79310753691be2472/indico/modules/events/editing/client/js/editing/timeline/util.js#L55

[ljharb]

@ThiefMaster i agree those are false positives. Can you file a new issue so we can track fixing it?