Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] destructuring-assignment: get the contextName correctly #3025

Merged
merged 1 commit into from Aug 9, 2021

Conversation

ohhoney1
Copy link
Contributor

correct #2929, for issue #2911

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could we get a regression test for this?

@ohhoney1
Copy link
Contributor Author

Thanks! Could we get a regression test for this?

@ljharb done

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #3025 (2459c00) into master (e8da096) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3025   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files         110      110           
  Lines        7294     7294           
  Branches     2665     2665           
=======================================
  Hits         7108     7108           
  Misses        186      186           
Impacted Files Coverage Δ
lib/rules/destructuring-assignment.js 98.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8da096...2459c00. Read the comment docs.

@ljharb ljharb changed the title [Fix]: destructuring-assignment get the contextName correctly [Fix] destructuring-assignment: get the contextName correctly Aug 9, 2021
@ljharb ljharb merged commit 2459c00 into jsx-eslint:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants