Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] destructuring-assignment, component detection: handle default export edge case #3038

Merged

Conversation

vedadeepta
Copy link
Contributor

Fixes: #3024

Added code to deal with ExportDefaultDeclaration as the parent node of a ArrowFunctionExpression

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #3038 (e324a19) into master (49e4bb6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3038   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files         111      111           
  Lines        7422     7426    +4     
  Branches     2711     2713    +2     
=======================================
+ Hits         7228     7232    +4     
  Misses        194      194           
Impacted Files Coverage Δ
lib/util/Components.js 98.75% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e4bb6...e324a19. Read the comment docs.

@vedadeepta vedadeepta force-pushed the 3024-exportDefault-component-detection branch from 1dcc058 to 0144d10 Compare August 10, 2021 11:46
@ljharb ljharb force-pushed the 3024-exportDefault-component-detection branch from 0144d10 to e324a19 Compare August 11, 2021 05:09
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@ljharb ljharb merged commit e324a19 into jsx-eslint:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

false positive in a simple function react/destructuring-assignment
3 participants