Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] jsx-pascal-case: add allowLeadingUnderscore option #3039

Merged
merged 1 commit into from Aug 12, 2021
Merged

[New] jsx-pascal-case: add allowLeadingUnderscore option #3039

merged 1 commit into from Aug 12, 2021

Conversation

mwaddell
Copy link
Contributor

Fixes #2603

  • Adds a new optional allowLeadingUnderscore property to the existing jsx-pascal-case rule.
  • Updates documentation to clearly explain when not to use it
  • Updates unit tests to ensure coverage

@mwaddell mwaddell changed the title Adding allowLeadingUnderscore option Adding allowLeadingUnderscore option to existing jsx-pascal-case rule Aug 11, 2021
ljharb
ljharb approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks

lib/rules/jsx-pascal-case.js Outdated Show resolved Hide resolved
@ljharb
Copy link
Member

ljharb commented Aug 12, 2021

@mwaddell however, because you made this PR from a fork you don't own, i can't rebase and force push to the PR branch (due to a github bug). can you add me to https://github.com/pangaeatech/eslint-plugin-react so i can land this?

@codecov-commenter

This comment has been minimized.

Sign in to view
@mwaddell mwaddell mentioned this pull request Aug 12, 2021
Merged
@mwaddell
Copy link
Contributor Author

Replaced by #3041 which is from my own repo instead of my company's

@mwaddell mwaddell closed this Aug 12, 2021
@ljharb

This comment has been minimized.

Sign in to view
@mwaddell mwaddell reopened this Aug 12, 2021
@ljharb ljharb changed the title Adding allowLeadingUnderscore option to existing jsx-pascal-case rule [New] jsx-pascal-case: add allowLeadingUnderscore option Aug 12, 2021
@ljharb ljharb merged commit e0c0812 into jsx-eslint:master Aug 12, 2021
@ljharb ljharb mentioned this pull request Feb 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsx-pascal-case: Allow leading underscore
3 participants
@mwaddell @ljharb @codecov-commenter