[Fix] prop-types, propTypes: handle React.* TypeScript types

[vedadeepta]

Fixes #3045 and related issues (#2786)

Implements logic discussed in this comment: #2777 (comment)

[codecov-commenter]

Codecov Report

Merging #3049 (a315a2f) into master (3d23496) will decrease coverage by 0.01%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #3049      +/-   ##
==========================================
- Coverage   97.42%   97.40%   -0.02%     
==========================================
  Files         111      111              
  Lines        7452     7472      +20     
  Branches     2726     2736      +10     
==========================================
+ Hits         7260     7278      +18     
- Misses        192      194       +2     

Impacted Files	Coverage Δ
lib/util/annotations.js	90.00% <ø> (ø)
lib/util/propTypes.js	96.95% <92.85%> (-0.26%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d23496...a315a2f. Read the comment docs.

[ljharb]

Thanks, looks great

[ljharb]

Does this solve #2777 as well?

[vedadeepta]

Does this solve #2777 as well?

Nope, it will show an error for code like this

interface Props {
    posts: string[];
}
const Home: NextPage<Props> = ({ posts }) => {
  return <span>jsx</span>
}

because NextPage is not in our allowedGenericTypes so line 945 will block the construction of declaredPropTypes from TS interface definition.

If we want this case to be handled we need to make allowedGenericTypes configurable by the user, or maybe there is a much cleaner way to solve this - I'm not really sure at the moment.

[ljharb]

ok - we can look into that in a followup. it'd be great to allow all generic types and actually respect what they declare.

[vedadeepta]

I actually forgot to handle the FunctionComponent<Props> or FC<Props> case. Will do it in a follow up PR.