Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] False positive in no-this-in-sfc #3056

Merged
merged 1 commit into from Aug 30, 2021
Merged

Conversation

Wesitos
Copy link
Contributor

@Wesitos Wesitos commented Aug 29, 2021

  • Modified getStatelessComponent method
  • Added check for functions assigned to properties (property name must be PascalCase)

Fixes #3054

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2021

Codecov Report

Merging #3056 (20caf10) into master (261d93a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 20caf10 differs from pull request most recent head 179550b. Consider uploading reports for the commit 179550b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3056   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         111      111           
  Lines        7491     7502   +11     
  Branches     2746     2755    +9     
=======================================
+ Hits         7298     7309   +11     
  Misses        193      193           
Impacted Files Coverage Δ
lib/util/Components.js 98.98% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261d93a...179550b. Read the comment docs.

lib/util/Components.js Outdated Show resolved Hide resolved
lib/util/Components.js Outdated Show resolved Hide resolved
@ljharb ljharb merged commit 179550b into jsx-eslint:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

react/no-this-in-sfc: eslint-plugin-react 7.25.0 interprets an old legacy jQuery plugin as a sfc
3 participants