Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] propTypes: add VoidFunctionComponent to react generic list #3092

Merged

Conversation

vedadeepta
Copy link
Contributor

Fixes #3090

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2021

Codecov Report

Merging #3092 (210865e) into master (783d4cd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3092   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         118      118           
  Lines        7855     7855           
  Branches     2801     2801           
=======================================
  Hits         7663     7663           
  Misses        192      192           
Impacted Files Coverage Δ
lib/util/propTypes.js 97.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783d4cd...210865e. Read the comment docs.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you

@ljharb ljharb force-pushed the 3090-generic-VoidFunctionComponent branch from c296418 to 210865e Compare October 1, 2021 19:38
@ljharb ljharb merged commit 210865e into jsx-eslint:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

bug is missing in props validation
3 participants