Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] prop-types, propTypes: add forwardRef<>, ForwardRefRenderFunction<> prop-types #3112

Merged
merged 1 commit into from Oct 24, 2021

Conversation

vedadeepta
Copy link
Contributor

Fixes: #3099

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021

Codecov Report

Merging #3112 (65eb9b6) into master (182e95d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3112   +/-   ##
=======================================
  Coverage   97.50%   97.51%           
=======================================
  Files         118      118           
  Lines        7870     7896   +26     
  Branches     2810     2823   +13     
=======================================
+ Hits         7674     7700   +26     
  Misses        196      196           
Impacted Files Coverage Δ
lib/util/propTypes.js 97.38% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182e95d...65eb9b6. Read the comment docs.

Comment on lines +115 to +116
// import { FC as X } from 'react' -> localToImportedMap = { x: FC }
const localToImportedMap = {};
Copy link
Member

@ljharb ljharb Oct 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this information not something eslint itself already provides?

(if so, we can update it in a followup)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean if it provides in a hashmap? Not sure, will inspect the ast sometime later and update here

Copy link
Member

@ljharb ljharb Oct 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in a hashmap - i believe eslint has a context method that takes a variable name or a node that references a variable or something, and gives you the node that defined it.

@ljharb ljharb merged commit 4bc3499 into jsx-eslint:master Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

is missing in props validation ForwardRefRenderFunction
3 participants