Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] destructuring-assignment, component detection: improve component detection #3122

Merged
merged 1 commit into from Nov 5, 2021

Conversation

vedadeepta
Copy link
Contributor

@vedadeepta vedadeepta commented Nov 5, 2021

Fixes: #3119

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #3122 (7b3d728) into master (0743c41) will decrease coverage by 0.00%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3122      +/-   ##
==========================================
- Coverage   97.46%   97.46%   -0.01%     
==========================================
  Files         119      119              
  Lines        8044     8076      +32     
  Branches     2867     2876       +9     
==========================================
+ Hits         7840     7871      +31     
- Misses        204      205       +1     
Impacted Files Coverage Δ
lib/util/jsx.js 93.68% <96.15%> (+0.93%) ⬆️
lib/util/Components.js 98.88% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0743c41...7b3d728. Read the comment docs.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ljharb ljharb force-pushed the 3119-component-detection-jsx branch from b34a7f8 to 7b3d728 Compare November 5, 2021 20:45
@ljharb ljharb changed the title [Fix] Components, jsx: improve component detection [Fix] destructuring-assignment, component detection: improve component detection Nov 5, 2021
@ljharb ljharb merged commit 7b3d728 into jsx-eslint:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

False positives in destructuring-assignment
3 participants