Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] jsx-no-target-blank: adjust options description #3124

Merged
merged 1 commit into from Nov 7, 2021
Merged

[Docs] jsx-no-target-blank: adjust options description #3124

merged 1 commit into from Nov 7, 2021

Conversation

gebsh
Copy link
Contributor

@gebsh gebsh commented Nov 6, 2021

Fixes #3123.

Additionally:

  • I added the missing warnOnSpreadAttributes option to the code block with a rule configuration.
  • Rearranged items on the enumeration list so that they match the order of options in the mentioned code block.
  • Adjusted formatting of those items so that all of them have the same style. (I chose the colon over the hyphen, as that's how most other rules have their options described.)

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #3124 (e672316) into master (7b3d728) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3124   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files         119      119           
  Lines        8076     8076           
  Branches     2876     2876           
=======================================
  Hits         7871     7871           
  Misses        205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3d728...e672316. Read the comment docs.

@ljharb ljharb merged commit e672316 into jsx-eslint:master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[jsx-no-target-blank] Option enforceDynamicLinks is described twice in docs
3 participants