[Docs] update react/jsx-runtime link
#3160
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Dec 22, 2021
README.md
Outdated
| @@ -31,7 +31,7 @@ Use [our preset](#recommended) to get reasonable defaults: | |||
| ] | |||
| ``` | |||
|
|
|||
| If you are using the [new JSX transform from React 17](https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html#removing-unused-react-imports), extend [`react/jsx-runtime`](https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/index.js#L163-L176) in your eslint config (add `"plugin:react/jsx-runtime"` to `"extends"`) to disable the relevant rules. | |||
| If you are using the [new JSX transform from React 17](https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html#removing-unused-react-imports), extend [`react/jsx-runtime`](https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/index.js#L168-L182) in your eslint config (add `"plugin:react/jsx-runtime"` to `"extends"`) to disable the relevant rules. | |||
There was a problem hiding this comment.
thanks! let's change this to a commit sha so it doesn't break again in the future.
There was a problem hiding this comment.
Thanks for your review.
Is this fix correct? db9bda0
ljharb
approved these changes
Dec 31, 2021
Codecov Report
@@ Coverage Diff @@
## master #3160 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 120 120
Lines 8265 8265
Branches 2975 2975
=======================================
Hits 8062 8062
Misses 203 203 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small issues with
react/jsx-runtimedocs