Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] prop-types, propTypes: add support for exported type inference #3163

Merged

Conversation

vedadeepta
Copy link
Contributor

@vedadeepta vedadeepta commented Dec 31, 2021

Fixes #3015

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #3163 (6a40d48) into master (4f54108) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3163   +/-   ##
=======================================
  Coverage   97.53%   97.54%           
=======================================
  Files         120      120           
  Lines        8245     8265   +20     
  Branches     2967     2975    +8     
=======================================
+ Hits         8042     8062   +20     
  Misses        203      203           
Impacted Files Coverage Δ
lib/util/ast.js 96.44% <100.00%> (+0.29%) ⬆️
lib/util/propTypes.js 97.41% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f54108...6a40d48. Read the comment docs.

@vedadeepta vedadeepta force-pushed the 3015-forward-ref-exported-types branch from 3e98f7a to dbc96bb Compare December 31, 2021 17:19
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lib/util/propTypes.js Outdated Show resolved Hide resolved
lib/util/propTypes.js Outdated Show resolved Hide resolved
@vedadeepta vedadeepta force-pushed the 3015-forward-ref-exported-types branch from dbc96bb to d477c12 Compare December 31, 2021 17:52
@ljharb ljharb force-pushed the 3015-forward-ref-exported-types branch from d477c12 to 6a40d48 Compare December 31, 2021 18:21
@ljharb ljharb merged commit 6a40d48 into jsx-eslint:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

forwardRef example has error in TypeScript
3 participants