Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] no-invalid-html-attribute: sort HTML_ELEMENTS and messages #3182

Merged
merged 1 commit into from Jan 27, 2022

Conversation

Primajin
Copy link
Contributor

Sorting things help me anticipate what the next item in the list will be and allow me to spot missing values, e.g. when there was no strong after strike I'd directly see that it would be missing.

Totally fine to do it in a separate PR, just makes this one harder to review :-)
Originally posted by @ljharb in #3174 (comment)

This is a pure chore commit - it only re-arranges/sorts the code - no additions or removals.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #3182 (541ea43) into master (4c668b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3182   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         120      120           
  Lines        8288     8288           
  Branches     2982     2982           
=======================================
  Hits         8085     8085           
  Misses        203      203           
Impacted Files Coverage Δ
lib/rules/no-invalid-html-attribute.js 96.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c668b3...541ea43. Read the comment docs.

@ljharb ljharb changed the title [chore] no-invalid-html-attribute: sort HTML_ELEMENTS and messages [Refactor] no-invalid-html-attribute: sort HTML_ELEMENTS and messages Jan 27, 2022
@ljharb
Copy link
Member

ljharb commented Jan 27, 2022

(I renamed it because the word "chore" is wildly inappropriate; chores are miserable things that you're forced to do by an authority figure :-) maintenance tasks and refactors are good things, and shouldn't invite that kind of connotation)

@ljharb ljharb merged commit 541ea43 into jsx-eslint:master Jan 27, 2022
@Primajin Primajin deleted the sort-items branch January 28, 2022 10:38
@Primajin
Copy link
Contributor Author

Hahaha 😅 OK! 👍🏻
I wasn't sure how much folks are into Conventional Commit style here. Refactor sounds much much better

@ljharb
Copy link
Member

ljharb commented Jan 28, 2022

That tooling is great, but unfortunately the actual style is terrible, and offers no way to configure it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants