[Fix] fix prefer-exact-props and improve performance
#3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meowtec
changed the title
prefer-exact-props and improve performanceprefer-exact-props and improve performance
Codecov Report
@@ Coverage Diff @@
## master #3190 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 120 120
Lines 8288 8288
Branches 2982 2982
=======================================
Hits 8085 8085
Misses 203 203
Continue to review full report at Codecov.
|
ljharb
force-pushed
the
performance/prefer-exact-props
branch
from
6b1b12a
to
4c668b3
Compare
ljharb
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
getStatelessComponentinstead ofgetParentStatelessComponentbecause the second will find the component to it's ancestors. That is incorrect and could cause performance problem.See the changed test case.