Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default value is now used if no right-hand value provided for numbers/strings #156

Merged
merged 1 commit into from Jan 28, 2019

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Jan 28, 2019

If default values are provided for an option, they will now be used if a flag is provided with no right-hand value.

fixes: #144

BREAKING CHANGE: a flag with no right-hand value no longer populates defaulted options with undefined.

Copy link
Contributor

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcoe bcoe merged commit 5a7c46a into master Jan 28, 2019
@bcoe bcoe deleted the address-145 branch January 28, 2019 18:49
@bcoe bcoe mentioned this pull request Feb 12, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default value should be used when the flag is specified with no value
2 participants