Skip to content

Commit

Permalink
fix: avoid legacy accessors (#2013)
Browse files Browse the repository at this point in the history
  • Loading branch information
bmeck committed Oct 7, 2021
1 parent 2324175 commit adb0d11
Showing 1 changed file with 17 additions and 7 deletions.
24 changes: 17 additions & 7 deletions index.cjs
Expand Up @@ -15,6 +15,20 @@ function Argv(processArgs, cwd) {
return argv;
}

function defineGetter(obj, key, getter) {
Object.defineProperty(obj, key, {
configurable: true,
enumerable: true,
get: getter,
});
}
function lookupGetter(obj, key) {
const desc = Object.getOwnPropertyDescriptor(obj, key);
if (typeof desc !== 'undefined') {
return desc.get;
}
}

/* Hack an instance of Argv with process.argv into Argv
so people can do
require('yargs')(['--beeble=1','-z','zizzle']).argv
Expand All @@ -28,16 +42,12 @@ function singletonify(inst) {
...Object.getOwnPropertyNames(inst.constructor.prototype),
].forEach(key => {
if (key === 'argv') {
Argv.__defineGetter__(key, inst.__lookupGetter__(key));
defineGetter(Argv, key, lookupGetter(inst, key));
} else if (typeof inst[key] === 'function') {
Argv[key] = inst[key].bind(inst);
} else {
Argv.__defineGetter__('$0', () => {
return inst.$0;
});
Argv.__defineGetter__('parsed', () => {
return inst.parsed;
});
defineGetter(Argv, '$0', () => inst.$0);
defineGetter(Argv, 'parsed', () => inst.parsed);
}
});
}

0 comments on commit adb0d11

Please sign in to comment.