zsh auto completion #1292
Merged
zsh auto completion #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
requested changes
Feb 12, 2019
lib/completion.js
Outdated
| @@ -79,8 +79,10 @@ module.exports = function completion (yargs, usage, command) { | |||
|
|
|||
| // generate the completion script to add to your .bashrc. | |||
| self.generateCompletionScript = function generateCompletionScript ($0, cmd) { | |||
| let zshShell = process.env.SHELL && process.env.SHELL.indexOf('zsh') !== -1 | |||
There was a problem hiding this comment.
I believe this could be const and not let.
| { | ||
| local reply | ||
| local si=$IFS | ||
| IFS=$'\n' reply=($(COMP_CWORD="$((CURRENT-1))" COMP_LINE="$BUFFER" COMP_POINT="$CURSOR" {{app_path}} --get-yargs-completions "$\{words[@]\}")) |
There was a problem hiding this comment.
interesting, at the end of the day this isn't too far off bash completion.
There was a problem hiding this comment.
yeah, not to much of a difference really.
| @@ -196,10 +196,21 @@ describe('Completion', () => { | |||
| }) | |||
|
|
|||
| describe('generateCompletionScript()', () => { | |||
| it('replaces application variable with $0 in script', () => { | |||
| it('replaces application variable with $0 in script (bash)', () => { | |||
| process.env.SHELL = '/bin/bash' | |||
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.