test: accept differently formatted output #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default for Node.js's `util.inspect` `compact` option might soon change to `3` which slightly changes the default output for objects. This change accepts both formats so that the test passes in all Node.js versions. Refs: nodejs/node#27109
4 tasks
|
@BridgeAR thanks for the patch. |
|
@bcoe is there a plan for a new version? |
jandockx
pushed a commit
to jandockx/yargs
that referenced
this pull request
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for Node.js's
util.inspectcompactoption might soonchange to
3which slightly changes the default output for objects.This change accepts both formats so that the test passes in all Node.js
versions.
Refs: nodejs/node#27109