Fix promise check to accept any spec conform object #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micha149
force-pushed
the
proper-promise-check
branch
from
4ec760f
to
e7aff27
Compare
|
😞Pipeline failed because of an timeout… Can somebody rebuild it? |
|
Travis CI build restarted |
An instanceof check only accept promises which are created using the `Promise` constructor. But there are other libraries which their own contructors. These promises should also work as long as they adhere to the spec.
micha149
force-pushed
the
proper-promise-check
branch
from
e7aff27
to
19cbaab
Compare
mleguen
approved these changes
Sep 18, 2019
|
Thanks @micha149 |
|
My pleasure. |
|
@micha149 thanks for the contribution 🎉 this should now be available in |
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this problem when I was creating a CLI tool which uses NodeGit internally. NodeGit is using its own fork of es6 promises and so yargs failed to handle my async code because it didn't return an instance of
Promise. But yargs should accept all promises as long as they are spec conform, regardless if its an native promise, a polyfill, a bluebird promise or any custom implementation.So, I fixed the code to look for thenable objects instead of making an instanceof check.