Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: groups were not being maintained for nested commands #1430

Merged
merged 2 commits into from Sep 27, 2019
Merged

fix: groups were not being maintained for nested commands #1430

merged 2 commits into from Sep 27, 2019

Conversation

mleguen
Copy link
Member

@mleguen mleguen commented Sep 25, 2019 •
edited

Closes #1173, closes #1081.

Mael LE GUEN added 2 commits September 25, 2019 13:08
tests: reproduce #1173
cf4ef37
fix: #1173
6f059aa 
Already preserved groups where not taken into account in reset()
when preserving groups
@mleguen mleguen changed the title Fix/1173 groups losts after 2 layers of commands Fix/1173 groups lost after 2 layers of commands Sep 25, 2019
@mleguen
Copy link
Member Author

mleguen commented Sep 25, 2019

Thanks Karl Horky for pointing out that Closes a, b in the PR description would only have closed the 1st issue, not the 2nd one. This is correct for Gitlab, not for Github which requires Closes a, closes b.

@karlhorky
Copy link

No worries, glad to help! Thanks for the PR!

@bcoe bcoe changed the title Fix/1173 groups lost after 2 layers of commands fix: groups were not being maintained for nested commands Sep 27, 2019
@bcoe bcoe merged commit d38650e into master Sep 27, 2019
@bcoe bcoe deleted the fix/1173 branch September 27, 2019 03:19
@bcoe
Copy link
Member

bcoe commented Oct 7, 2019

@mleguen when you get a second to confirm, this fix should have been released in 14.2.0.

@mleguen
Copy link
Member Author

mleguen commented Oct 9, 2019

Thanks @bcoe , looks good to me.

This was referenced Nov 25, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mleguen @karlhorky @bcoe