feat!: drop support for EOL Node 8 #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
commented
Jul 5, 2020
| @@ -1,2 +0,0 @@ | |||
| releaseType: node | |||
There was a problem hiding this comment.
this functionality was replaced with a GitHub Action.
| if (process && process.version) { | ||
| const major = Number(process.version.match(/v([^.]+)/)[1]) | ||
| if (major < minNodeVersion) { | ||
| throw Error(`yargs supports a minimum Node.js version of ${minNodeVersion}. Read our version support policy: https://github.com/yargs/yargs#supported-nodejs-versions`) |
There was a problem hiding this comment.
I've started throwing on unsupported versions of Node.js, otherwise folks can get bit somewhere down the road, e.g., when we pull in a feature like async generators, which aren't supported in Node 8.
This was referenced Jul 6, 2020
Closed
This was referenced Jul 19, 2020
Closed
Merged
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for end of life Node 8.
Notes:
yargs@15.4.0was released a few days ago, which includes much of @mleguen's work migrating to TypeScript (we should be mindful that we might need to port a few fixes back to this release line.).yargs@16.x.xuntil we've finished the full TypeScript conversion, this includes @QmarkC's work on yargs-parser.