New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(completion): positional arguments completion #2090
Conversation
@zuozp8 thank you for the contribution 👏 will provide review as soon as possible. |
80f2db8
to
c195db4
Compare
@bcoe I rebased my branch as there were conflicts I would be grateful if you could review (and release) it soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, I appreciate the tests being fleshed out.
|
@zuozp8 thank you for the great contribution. |
@bcoe could you make a release with my changes? |
@zuozp8 it's released now with your changes, thanks for the great contributions, and sorry for the slow turnaround (it's been a very busy month.) |
It will be convinient for reviewers to look at commits separately: