Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser.d.ts and check for existence of Error.captureStackTrace() #2144

Merged
merged 7 commits into from Apr 20, 2022

Conversation

codetheweb
Copy link
Contributor

I'm attempting to use this in a browser environment and have run into a few issues.

@bcoe
Copy link
Member

bcoe commented Mar 19, 2022

Thanks for the patch 😄

@codetheweb in Chromium at least, Error.captureStackTrace is a method. I'm curious what environment is giving you trouble?

@codetheweb
Copy link
Contributor Author

It's not available in Firefox unfortunately.

@bcoe bcoe merged commit 6192990 into yargs:main Apr 20, 2022
@bcoe
Copy link
Member

bcoe commented Apr 20, 2022

@codetheweb thank you for the contribution.

@hongaar
Copy link
Contributor

hongaar commented May 12, 2022

The browser.d.ts is not available from NPM, added a commit to #2185 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants